From 6f1f65947c52a0c9eed2c4cd8dfb55694ea2eeaf Mon Sep 17 00:00:00 2001 From: Tatsuya Kinoshita Date: Fri, 26 Feb 2021 19:38:20 +0900 Subject: Fix integer overflow due to Strgrow Bug-Chromium: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31397 --- Str.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'Str.c') diff --git a/Str.c b/Str.c index 61fe3ca..7e86f83 100644 --- a/Str.c +++ b/Str.c @@ -21,10 +21,12 @@ #ifdef __EMX__ /* or include "fm.h" for HAVE_BCOPY? */ #include #endif +#include #include "Str.h" #include "myctype.h" #define INITIAL_STR_SIZE 32 +#define STR_SIZE_MAX INT_MAX #ifdef STR_DEBUG /* This is obsolete, because "Str" can handle a '\0' character now. */ @@ -237,9 +239,12 @@ Strgrow(Str x) newlen = x->area_size * 6 / 5; if (newlen == x->area_size) newlen += 2; + if (newlen < 0 || newlen > STR_SIZE_MAX) + newlen = STR_SIZE_MAX; x->ptr = GC_MALLOC_ATOMIC(newlen); x->area_size = newlen; bcopy((void *)old, (void *)x->ptr, x->length); + x->ptr[x->length] = '\0'; GC_free(old); } -- cgit v1.2.3