From 89e60cc474fca9050048cf5cd9444f8dd7070cf7 Mon Sep 17 00:00:00 2001 From: "Kyle J. McKay" Date: Wed, 23 Aug 2017 13:14:23 -0700 Subject: form.c: do not gratuitously turn GET into POST When encountering a
tag that contains these values: method="get" enctype="multipart/form-data" Do not transform the method into POST to accomodate enctype. Instead behave in the compatible way that all other browsers behave in this instance and ignore the enctype parameter (treating it as the default application/x-www-form-urlencoded) and perform a "GET" just as the method parameter requests. This behavior produces far more compatible results than gratuitously changing the "get" into a "post" which can result in unexpected "405 Method Not Allowed" errors. Signed-off-by: Kyle J. McKay --- form.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'form.c') diff --git a/form.c b/form.c index 0605513..cc5e3d2 100644 --- a/form.c +++ b/form.c @@ -56,10 +56,9 @@ newFormList(char *action, char *method, char *charset, char *enctype, m = FORM_METHOD_INTERNAL; /* unknown method is regarded as 'get' */ - if (enctype != NULL && !strcasecmp(enctype, "multipart/form-data")) { + if (m != FORM_METHOD_GET && enctype != NULL && + !strcasecmp(enctype, "multipart/form-data")) { e = FORM_ENCTYPE_MULTIPART; - if (m == FORM_METHOD_GET) - m = FORM_METHOD_POST; } #ifdef USE_M17N -- cgit v1.2.3